-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the unfollow
action in the frozen phase
#81434
Allow the unfollow
action in the frozen phase
#81434
Conversation
The `unfollow` actions is injected before some of the actions that yield the managed index unsafe to use in a CCR environment (eg. rollover, searchable_snapshot, shrink). This was not allowed in the `frozen` phase, however we do have the `searchable_snapshot` action available. This commit makes the `unfollow` action available in the frozen phase.
Pinging @elastic/es-data-management (Team:Data Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but we have a serious mismatch for it in the HLRC's LifecyclePolicy (which has its own set of allowed actions, it's entirely missing the frozen
phase!)
I opened #81461 for fixing that.
* Allow the `unfollow` action in the frozen phase The `unfollow` actions is injected before some of the actions that yield the managed index unsafe to use in a CCR environment (eg. rollover, searchable_snapshot, shrink). This was not allowed in the `frozen` phase, however we do have the `searchable_snapshot` action available. This commit makes the `unfollow` action available in the frozen phase.
💔 Backport failed
You can use sqren/backport to manually backport by running |
* Allow the `unfollow` action in the frozen phase The `unfollow` actions is injected before some of the actions that yield the managed index unsafe to use in a CCR environment (eg. rollover, searchable_snapshot, shrink). This was not allowed in the `frozen` phase, however we do have the `searchable_snapshot` action available. This commit makes the `unfollow` action available in the frozen phase. (cherry picked from commit 8ba6f55) Signed-off-by: Andrei Dan <[email protected]> # Conflicts: # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleTypeTests.java
* Allow the `unfollow` action in the frozen phase (#81434) * Allow the `unfollow` action in the frozen phase The `unfollow` actions is injected before some of the actions that yield the managed index unsafe to use in a CCR environment (eg. rollover, searchable_snapshot, shrink). This was not allowed in the `frozen` phase, however we do have the `searchable_snapshot` action available. This commit makes the `unfollow` action available in the frozen phase. * Fix testValidateFrozenPhase (#81479) Always add the `searchable_snapshot` action in the frozen phase. (cherry picked from commit cd344e3) Signed-off-by: Andrei Dan <[email protected]>
* Allow the `unfollow` action in the frozen phase The `unfollow` actions is injected before some of the actions that yield the managed index unsafe to use in a CCR environment (eg. rollover, searchable_snapshot, shrink). This was not allowed in the `frozen` phase, however we do have the `searchable_snapshot` action available. This commit makes the `unfollow` action available in the frozen phase. (cherry picked from commit 8ba6f55) Signed-off-by: Andrei Dan <[email protected]> # Conflicts: # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleTypeTests.java
The
unfollow
actions is injected before some of the actions that yieldthe managed index unsafe to use in a CCR environment (eg. rollover,
searchable_snapshot, shrink).
This was not allowed in the
frozen
phase, however we do have thesearchable_snapshot
action available.This commit makes the
unfollow
action available in the frozen phase.